Digital-Sapphire / PyUpdater

Pyinstaller auto-update library
https://www.pyupdater.org
460 stars 92 forks source link

Config confusion #323

Closed dennisvang closed 2 years ago

dennisvang commented 2 years ago

The term "config" is used ambiguously:

This can be quite confusing. For example, PackageHandler.init gets a config argument, which receives a Config instance, which is not stored (only the value of "UPDATE_PATCHES" is stored). The initializer also defines a self.config attribute, but this has nothing to do with the config argument: it becomes a dict with the content of "py_repo_config" (in PackageHandler._load_config).

Some other points: