233 implement new marker designs

DigitalCommons / land-explorer-front-end

React app for the Land Explorer front end

http://landexplorer.cc

GNU Affero General Public License v3.0

1 stars 0 forks source link

233 implement new marker designs #240

Closed ms0ur1s closed 1 year ago

ms0ur1s commented 1 year ago

What? Why?

Closes #233

Implementation of new marker designs.

Updates to the CSS and mark-up
componentisation of DrawingPopup
A little re-factoring and at least one bug fix

What should we test?

Test the functionality of the new dialogue boxes across multiple devices.
Look out for any newly introduced bugs

For my own peace of mind I'll also be testing this once on staging.

King-Mob commented 1 year ago

@ms0ur1s is this meant to be in review? i can see i've been requested but it's in the in progress column

ms0ur1s commented 1 year ago

@King-Mob , thanks for the nudge man. Yes, this should have been in the review column.

lin-d-hop commented 10 months ago

Am I right that this still needs to be deployed to staging?

King-Mob commented 10 months ago

@lin-d-hop there hasn't been a new PR attached to the issue since it went back to in progress. So, this PR is on staging but I don't think the content of the PR resolves the last comment on issue #233

ms0ur1s commented 10 months ago

@lin-d-hop , @King-Mob I'll merge the latest dev into #233 and create a new PR. Is it ok if I do this first thing tomorrow, so that I can maintain today's flow on my current issue?

King-Mob commented 10 months ago

@ms0ur1s @lin-d-hop should this be in review or QA or ready to go? currently in review but I'm not sure what I'm supposed to be reviewing