search

DigitalCommons / land-explorer-front-end

React app for the Land Explorer front end
http://landexplorer.cc
GNU Affero General Public License v3.0
1 stars 0 forks source link

Update link to privacy policy #242

Closed lin-d-hop closed 10 months ago

lin-d-hop commented 1 year ago

Describe the bug During the registration flow the the Privacy Policy link is broken. This needs to be fixed

To Reproduce Steps to reproduce the behavior:

  1. Log out and hit Register
  2. Click on the Privacy Policy link
  3. See error

Expected behaviour You should see a pdf of this doc: https://docs.google.com/document/d/14tc9m_bC4LL1CaKuNeaneExixWsOa8d27JJjI8h2LeA/edit

ms0ur1s commented 1 year ago

@lin-d-hop, should this document be hosted on sharedassets.org.uk?

lin-d-hop commented 1 year ago

nope. Probably should be hosted on the local server?

ms0ur1s commented 1 year ago

Cool are you ok with me renaming the pdf to just privacy-policy as in the twine example?

@King-Mob, is it ok if this lives in the public folder of the LX codebase?

King-Mob commented 1 year ago

@ms0ur1s slight hesitation just on file size. it seems like this could easily be a webpage? is there a reason it needs to be a pdf? @lin-d-hop

if it needs to be a pdf, then having in the public folder is fine

ms0ur1s commented 1 year ago

Cool @King-Mob, current file size is 78kb

ms0ur1s commented 1 year ago

I'll wait for @lin-d-hop to respond before progressing.

lin-d-hop commented 1 year ago

It doesn't have to be a PDF. We could make if a public pdf on the GDrive. But is 78kb really a concerning file size?

ms0ur1s commented 1 year ago

Will go with the PDF, for now, and we can knock up a page if / when necessary.