[Backsearch P1] [Ownership panel] Select and deselect all links

lin-d-hop commented 10 months ago

[EDIT]

Clear all is implemented, though let's think about the UX here as it is not quite right.

Select all still to be completed.

Updated acceptance criteria

'Select all' link that selects all of the properties as if a user had clicked on them all.
Error handling in the case that 'Select all' creates an action too large for the server to handle.

Probably we'll make new issues for this work.... but moving this back for now

Description

After a chat this morning we've identified a set of UX improvements that will improve the Ownership Search panel.

The updated designs have a 'Select all' already, so let's work to this. We want to additionally add a 'Clear all'. I'm not sure how these should align with each other, but let's work to something that will still be mobile friendly :)

Acceptance Criteria

'Select all' link that selects all of the properties as if a user had clicked on them all.
'Clear all' link that clears all ownership search.
'Clear all' should also deselect the properties. This will mean that these properties are also no longer appearing in the 'Land Information' panel. If there are other properties selected in the 'Land Information' panel that don't pertain to the current 'Land Ownership' search then they should remain.
When there are no properties in the ownership search then after the user closes the panel the 'Ownership Search' icon should disappear from the tool bar.

ms0ur1s commented 10 months ago

Updated image to match current iteration of the ownership search

ms0ur1s commented 10 months ago

Arrow SVGs

icon-arrow-grey icon-arrow-green

ms0ur1s commented 10 months ago

height: 16px in above design

lin-d-hop commented 10 months ago

Select all on large datasets gives the worst possible experience. White screen of death and you have to totally refresh the page.

https://github.com/DigitalCommons/land-explorer-front-end/assets/8669848/9f246698-e9e7-4bef-a27a-2f14155fa135

ColmDC commented 10 months ago

Select All Currently Visible in the List would also not be very useful atm, as there is currently no geographical coherence to the order they appear in the list. We would need to support that first. See #279 for thoughts on this.

lin-d-hop commented 9 months ago

@rogup @ms0ur1s Let's uncomment this for testing with the error messaging issues :)

rogup commented 9 months ago

Added the select all button and ready for QA. (I didn't send for review since it was literally just uncommenting one line of code)

lin-d-hop commented 9 months ago

@rogup has this been deployed to staging? I couldnt see the box just now...

rogup commented 9 months ago

@lin-d-hop Sorry, there was a problem with the hook-runner so the changes weren't automatically deployed. I'm not sure on the exact reason why (there were some user access issues on the server), but it's working again now

DigitalCommons / land-explorer-front-end