search

DigitalCommons / land-explorer-front-end

React app for the Land Explorer front end
http://landexplorer.cc
GNU Affero General Public License v3.0
1 stars 0 forks source link

Weird UX when there are duplicate properties added via backsearch #292

Open rogup opened 7 months ago

rogup commented 7 months ago

Describe the bug Since there are now 'Properties' and 'Related Properties' in the Info pane, it can lead to confusing UX if we add the same property as a related property.

To Reproduce Steps to reproduce the behavior:

  1. Click on a property boundary
  2. Check for other properties
  3. Highlight the same property
  4. It now shows a duplicate item, but as a 'Related Property'
  5. If we try to select one of the items, both items expand (since they are keyed off the same polygon ID, which should be unique and we assume is unique throughout lots of the app). The way that properties are highlighted when they are clicked/expanded also differs between Properties and Related Properties.

Expected behaviour More consistent UX

Do we need to differentiate between 'Properties' and 'Related Properties' in the info pane? I'm wondering if we could just show them all as properties in the same way, including those that the user selects using backsearch. This would simplify the code a lot too. @ms0ur1s @lin-d-hop what do you think, since you maybe have more context about how this feature is being used

ms0ur1s commented 7 months ago

@rogup, tbh I left this in by mistake. I changed the title so I could differentiate during development. So it shouldn't really be there. 😬

rogup commented 7 months ago

@ms0ur1s Ah cool, no worries. So I'm thinking we could actually simplify the code a lot by just adding any related properties to the same collection of properties we already had in LandOwnershipReducer.

This would allow us to remove some duplicated code relating to related properties and the highlighting of them, which would speed up development.

I'll add to the bug backlog, since I think it can wait until after the current Backsearch P1 and P2 issues

ms0ur1s commented 7 months ago

Great @rogup, that makes 100% sense. This one might be a good opportunity for a pair up, if you're interested.

rogup commented 7 months ago

@ms0ur1s Sure, happy to pair on this when it comes round to it :)