Open rogup opened 11 months ago
@rogup, tbh I left this in by mistake. I changed the title so I could differentiate during development. So it shouldn't really be there. 😬
@ms0ur1s Ah cool, no worries. So I'm thinking we could actually simplify the code a lot by just adding any related properties to the same collection of properties we already had in LandOwnershipReducer.
This would allow us to remove some duplicated code relating to related properties and the highlighting of them, which would speed up development.
I'll add to the bug backlog, since I think it can wait until after the current Backsearch P1 and P2 issues
Great @rogup, that makes 100% sense. This one might be a good opportunity for a pair up, if you're interested.
@ms0ur1s Sure, happy to pair on this when it comes round to it :)
Describe the bug Since there are now 'Properties' and 'Related Properties' in the Info pane, it can lead to confusing UX if we add the same property as a related property.
To Reproduce Steps to reproduce the behavior:
Expected behaviour More consistent UX
Do we need to differentiate between 'Properties' and 'Related Properties' in the info pane? I'm wondering if we could just show them all as properties in the same way, including those that the user selects using backsearch. This would simplify the code a lot too. @ms0ur1s @lin-d-hop what do you think, since you maybe have more context about how this feature is being used