DigitalCommons / land-explorer-front-end

React app for the Land Explorer front end
http://landexplorer.cc
GNU Affero General Public License v3.0
1 stars 0 forks source link

[LX Collab Mapping] Design and implement Share Map UI #308

Closed lin-d-hop closed 3 months ago

lin-d-hop commented 5 months ago

Please track under the clockify project [LX Collab Mapping]

Description

Following on from #304

Redesign the Share map screen. Currently the UX is a little confusing, so it would be good to tidy up redundant elements. But the core purpose of this issue is to enable a user to assign access permissions to a user when they are sharing the map.

Current share map: Screenshot from 2024-01-19 14-59-03

inspiration: Screenshot from 2024-01-16 15-57-11

Acceptance Criteria

ms0ur1s commented 5 months ago

Hi @lin-d-hop, just dropped a couple of screenshots below. The second just has the dropdown exposed.

image

image

ms0ur1s commented 5 months ago

FE now posts chosen access rights to the BE. As with BE #307, only owner status needs to be resolved. (Selected Value displayed below for testing purposes only)

image

lin-d-hop commented 4 months ago

These are great @ms0ur1s. Is there anything you need to progress this?

ms0ur1s commented 4 months ago

These are great @ms0ur1s. Is there anything you need to progress this?

No @lin-d-hop, #308 work is completed, only #306 work outstanding, which I'm organising with Rohit so it can be resolved.

image

rogup commented 3 months ago

I did a bit of testing of this and it turns out that the existing backend code for sharing maps was quite buggy, so I needed to fix and re-write a fair bit of it.

Also, I found the pills a bit confusing because they look like they should show the current share state of the map, but weren't displaying this info, so it wasn't clear whether sharing to a new user would remove access to a previous user. And re-sharing a map with a different access level to the same user didn't seem to work. I've updated things so that it's more similar to the GDocs experience, where all current users with access are shown.

All these changes are within the PR linked to #306 so I'll close this ticket