Closed rogup closed 1 month ago
I think multiple-valued items like this:
"DC Domains": "test.coop;testlong.coop",
Would be better as arrays?
"DC Domains": ["test.coop","testlong.coop"],
Using delimiters can be a bit fraught in general, as you need to either pick one which cannot legitimately appear in the data or implement an escaping rule.
Necessary sometimes with CSV, but I think this can be entirely avoided in JSON.
One thought about the "member of" fields. Perhaps these would need to be (or more conveniently be) collapsed into a single field, perhaps an array or an object.
Whether this is true or not depends a bit on how we handle them in the filters - the UI design I've seen wants them to be one filter, not N filters.
I think multiple-valued items like this:
"DC Domains": "test.coop;testlong.coop",
Would be better as arrays?
"DC Domains": ["test.coop","testlong.coop"],
Using delimiters can be a bit fraught in general, as you need to either pick one which cannot legitimately appear in the data or implement an escaping rule.
Necessary sometimes with CSV, but I think this can be entirely avoided in JSON.
Updated this
One thought about the "member of" fields. Perhaps these would need to be (or more conveniently be) collapsed into a single field, perhaps an array or an object.
Whether this is true or not depends a bit on how we handle them in the filters - the UI design I've seen wants them to be one filter, not N filters.
Yes, good idea. I think this makes more sense.
Although I don't think they're always a 'member of' each of them e.g. DotCoop. I'll call the field 'data_sources' since this matches with the popup design https://xd.adobe.com/view/3ef8c8d0-84bb-480e-bdfe-113d11f1583b-6bab/screen/2cccf667-44b9-4e12-ac7e-3c1c9d17eb60/
All good for merging I think.
These changes were re-added after Nick's API changes, along with some small changes to fix the UTs 328f013f90dac854d8ed6a37955e79aab1a413e4
What? Why?
Related to issue #20
In our delivery meeting, we confirmed that this mock data covers all the fields we need in the Delhi demo
We need to add some demo JSON files based on this, so we can start adding UTs.
Checklist
docs/