Open ms0ur1s opened 1 month ago
https://xd.adobe.com/view/cd4c3f0e-21ad-49ad-9670-12136cacd8ee-981f/
https://xd.adobe.com/view/120a9e57-bdd3-4ed6-9268-f33fe843044b-4759/
https://xd.adobe.com/view/3ef8c8d0-84bb-480e-bdfe-113d11f1583b-6bab/
https://xd.adobe.com/view/f51ee4af-db90-4bda-9806-d10c7d7d0f36-a04d/
@ColmDC and @lin-d-hop is the issue I've created ok?
@ColmDC, working on this issue until PR 38 is merged into main and I can merge main back into branch 272-integrate-main-and-results-panels (this might be a rebase rather than a merge).
@ms0ur1s what's the purpose of the 272-integrate-main-and-results-panels branch? It looks like it doesn't have any commits ahead of main
@ms0ur1s what's the purpose of the 272-integrate-main-and-results-panels branch? It looks like it doesn't have any commits ahead of main
@rogup, sorry man I created this branch before I realised I needed the results panel stuff merged in before I could started it. I could rebase this branch or it might be easier just to start a new one of main now that PR38's merged in.
@ms0ur1s I've given it a quick review and it looks good so far. Is the PR finished, or is there more to do?
@rogup, might be a bit or refactoring needed to iron out the kinks in the mobile version (though the mobile version is working). If I haven't updated the PR by the time you're online, do you mind merging it in and I'll stash any further changes and re-instate then in new branch?
@rogup, still in the process of switching this over to use a different MUI component. So you might as well merge this pop-up so that at least there's something there.
@ms0ur1s I've merged in that branch
@rogup, nice one. Thanks man
Just noticed this issue - the pop up component looks done and live. Is there something else outstanding in this? @ms0ur1s @rogup
@lin-d-hop I think @ms0ur1s was maybe meaning to do a couple of tweaks relating to scrolling, but he can confirm when he's back
We could create tickets for outstanding documentation and accordian feature, then close.
Any further tweaks relating to scrolling can be new tickets too.
Description
Create a Pop-up component based on the designs detailed in issue #22. The component should contain all the fields displayed in the aforementioned design, as well as providing for extra fields that a specific data source might contain. The component should be designed for both desktop and mobile layouts and follow the specified structure and functionality:
Component Breakdown
Co-op Name
,Primary Activity
,Description
and.coop Domains
.Address
andWebsite
fields. Bottom section to contain:Organisational Structure
,Typology
, andData Sources
list.Redux Integration
Storybook Stories
Tasks
Acceptance Criteria