Rename getDataset - Githubissues

DigitalCommons / mykomap-monolith

A web application for mapping initiatives in the Solidarity Economy

0 stars 0 forks source link

Rename getDataset #34

Closed wu-lee closed 3 weeks ago

wu-lee commented 4 weeks ago

What? Why?

Related to issue #26

The name getDataset suggests something which doesn't happen.

I've not followed the suggestion exaxctly, see the comment in the first commit.

What should we test?

Test all the tests run ok and the app still nominally works when run.

Checklist

[x] Updated or added any necessary docs in docs/ [N/A]
[x] Added UTs [N/A I believe]
[x] Checked that all automated tests pass

Deployment notes

N/A

wu-lee commented 4 weeks ago

Note this branch is currently tacked onto the end of another branch under review. It's not as long as it appears! Will need to be rebased back onto main later.

wu-lee commented 3 weeks ago

Having answered @rogup question directly, the reviewer seems to be happy for this to be merged, which is now done. (See above for the merge commit, which references this PR. There was some rebasing to do since it was chained onto another branch for operational reasons, hence the merge done in git outside of GitHub, which makes it think this was closed rather than merged.)