DigitalCommons / mykomap

A web application for mapping initiatives in the Solidarity Economy
3 stars 0 forks source link

Korean language support #126

Closed ColmMassey closed 2 years ago

ColmMassey commented 2 years ago

Extend sea-map to support non latin languages, using Korean as an example.

ColmMassey commented 2 years ago

Do we still need to do any plumbing before we can support non latin langages in our Linked Data publication as well as in sea-map? @King-Mob @wu-lee ?

wu-lee commented 2 years ago

Do we still need to do any plumbing before we can support non latin langages in our Linked Data publication as well as in sea-map? @King-Mob @wu-lee ?

Without looking at the code, I'd say quite possibly, yes. Are you including languages which don't write left-to-right, like Arabic? Korean, so far as I know, can go left-to-right, when it's not top-top-bottom.

Other than that, I would guess it's an issue of complete Unicode support, which doesn't always Just Work, because encodings can trip you up.

King-Mob commented 2 years ago

I've made a branch with a set of Korean labels that as far as I can tell works fine.

Without corresponding Korean vocabs and data though, the map and the initiatives aren't available.

@ColmMassey Would it make sense to fall back to English vocabs and data when we don't have a translation?

ColmMassey commented 2 years ago

@ColmMassey Would it make sense to fall back to English vocabs and data when we don't have a translation?

Yes. Good idea.

ColmMassey commented 2 years ago

I can see some Korean text in the spreadsheet. Are you happy for me to ask ICA to start to populate it now? @King-Mob?

King-Mob commented 2 years ago

Yes please

wu-lee commented 2 years ago

I've deployed a Korean-enabled version of the ica-project. You can view it here:

https://dev.ica.solidarityeconomy.coop/?language=KO

Note that it's loading Spanish, French and English vocab terms as well, and this seems to mean the vocab loading takes about 30 seconds! Even though there are not any actual Korean tranlations for the vocabs yet.

ColmMassey commented 2 years ago

Note that it's loading Spanish, French and English vocab terms as well, Do you mean it has to always load all supported vocabularies? Is this becasue if a korean term is missing it needs to use the default?

Regardless I think we need to take a look at this with an optimisation lense and get those load times down to something managable. Hopefully there will be a few easy changes that could speed it up.

wu-lee commented 2 years ago

See https://github.com/SolidarityEconomyAssociation/sea-map/issues/133

wu-lee commented 2 years ago

Also https://github.com/SolidarityEconomyAssociation/sea-map/issues/134

King-Mob commented 2 years ago

review here: https://dev.ica.solidarityeconomy.coop/?language=KO

wu-lee commented 2 years ago

DotCoop map updated to sea-map 1.x and se-open-data 2.x (so ESSGLOBAL 2.1)

Korean, Spanish, and French translations added for about panel, and country names.

https://dev.dotcoop.solidarityeconomy.coop/?language=KO https://dev.dotcoop.solidarityeconomy.coop/?language=FR https://dev.dotcoop.solidarityeconomy.coop/?language=ES

wu-lee commented 2 years ago

ICA Youth Network already on sea-map 1.x and ESSGLOBAL 2.1, but data regenerated to get new country translations, and FR, ES, KO localisations added:

https://dev.ica-youth-network.solidarityeconomy.coop/?language=KO https://dev.ica-youth-network.solidarityeconomy.coop/?language=FR https://dev.ica-youth-network.solidarityeconomy.coop/?language=ES

wu-lee commented 2 years ago

ICA map (see above) had some sort of error with KO, redeployed and now it seems to be ok witn KO (possibly an older version?)

Also, regenerated data, so KO language countries also working.

wu-lee commented 2 years ago

Activities and org-stucture vocabs still not available in KO for ICA or ICA Youth.

I'm going away on a long weekend trip tomorrow afternoon, back Sunday, so I may or may not get to fix that.

If not, and @King-Mob gets the time to add Korean translations to the vocabs in map-sse under vocabs/standard/*.ttl, the method to redeploy any updated vocabs is as follows.

First, you'll need ssh and an alias dev-1 defined in your ssh config pointing at the host dev-1.solidarityeconomy.coop, as the alias is used below.

Then:

However the ica data needs to be rebuilt to get these live on the site. This is how (although untested in full):

The password-store is possibly a point where you may run into problems, because you may need your GnuPG keychain set up, and have imported all the public keys in keys/. There are instructions in the repo, I think they are complete.

Having written all this it seems a bit of an obstacle course to navigate in a hurry - which emphasises the need to communicate it all properly when it's convenient to.

ColmMassey commented 2 years ago

Search is broken in Korean version, so returning it to In Progress at the top of the list.

King-Mob commented 2 years ago

@ColmMassey This was because we have 1 korean vocab (countries) but no other ones. The code was assuming that if we had 1 set of vocabs then we had all 6. I've changed that to be applied per vocab now, so the dropdowns can be in mixed languages.

King-Mob commented 2 years ago

up on the dev site: https://dev.ica.solidarityeconomy.coop/?language=KO

ColmMassey commented 2 years ago

Drop downs in Korean search now working again. :-)

ColmMassey commented 2 years ago

It's not clear why some terms have Korean translations and some not. This spreadsheet should be the primary source for translations. https://nextcloud.solidarityeconomy.coop/index.php/apps/onlyoffice/s/i8dNYqbmj7MXrax

I note also that some of the French and Spanish terms have been translated in the app, but not copied into the spreadsheet. Can we realingn them? Perhaps ask @tomdavidson so he can get familiar with how we are managing mutlilingual data?

ColmMassey commented 2 years ago

I've gotten a Korean friend to finish the translations! They are in the spreadsheet. Can you use these ones now? So we need them on ICA, Dotcoop and ICA Youth, in that order of impotance on dev. Signal me, so I can test them ASAP before we push to prod. @wu-lee were there any issues with the Korean on the Dotcoop site?

tomdavidson commented 2 years ago

@ColmMassey the wrong tom but thanks for bringing solidarityeconomy.coop to my attention - way cool.

wu-lee commented 2 years ago

were there any issues with the Korean on the Dotcoop site?

Not to my knowledge - the drop downs work, presumably because there is only one vocab and that's got Korean.

ColmMassey commented 2 years ago

Getting

It's not clear why some terms have Korean translations and some not. This spreadsheet should be the primary source for translations. https://nextcloud.solidarityeconomy.coop/index.php/apps/onlyoffice/s/i8dNYqbmj7MXrax

I note also that some of the French and Spanish terms have been translated in the app, but not copied into the spreadsheet. Can we realingn them? Perhaps ask @tomdavidson so he can get familiar with how we are managing mutlilingual data?

@ThomasDavisonsGit

ColmMassey commented 2 years ago

@King-Mob When can you get the new Korean translations into the ICA maps?

King-Mob commented 2 years ago

I'm working on it now. Should be up in ten minutes

King-Mob commented 2 years ago

New translations are in the ICA map. Working on Dotcoop and ICA Youth now

ColmMassey commented 2 years ago

There still seems to be lots of areas that are using English terms.

wu-lee commented 2 years ago

This spreadsheet should be the primary source for translations. https://nextcloud.solidarityeconomy.coop/index.php/apps/onlyoffice/s/i8dNYqbmj7MXrax

This is now updated with the latest vocab localisation data (currently has non-localised data too, this helps to round-trip the data)

sea-map related phrases have been moved to their own tab.

ColmMassey commented 2 years ago

Pretty comprehensive!

ColmMassey commented 2 years ago

I don't think we could use it to get translations from third parties though. How should we do that?

wu-lee commented 2 years ago

Well, we could remove or hide the parts with no translation required? (The bits which inherently have no localisation, and maybe also the bits with no localisation needed from the 3rd party in question.)

That would need to be manual initially, I'm not sure of the scope for automating that in an OnlyOffice spreadsheet. Some sort of web UI might be better for automating that.

ColmMassey commented 2 years ago

I think a few manual steps are fine. Let's test with the last tweaks of the Korean translations.

wu-lee commented 9 months ago

@ColmMassey - looks like this should be closed?

ColmDC commented 9 months ago

@ColmMassey - looks like this should be closed?

Is it not closed already?

wu-lee commented 9 months ago

Hm, yes it is. Ignore me.