search

DigitalCommons / mykomap

A web application for mapping initiatives in the Solidarity Economy
3 stars 0 forks source link

adapt sea-map run-scripts for npm v7+ #143

Closed wu-lee closed 1 year ago

wu-lee commented 2 years ago

The NPM maintainers, in their wisdom, have decided to remove a feature we use in our run-scripts for building and deploying. As such, we can't use versions of NPM newer than 6 (7 or higher) until we find a way around this missing feature.

See: https://github.com/npm/cli/issues/2452#issuecomment-1028142496 https://github.com/npm/rfcs/issues/305

ColmMassey commented 1 year ago

When might we need to address this? @wu-lee

wu-lee commented 1 year ago

I've needed to bump the version of node in use to a recent one (16.*, i.e. lts/gallium) in order to get an implementation of Promise.all, used in the sparql-bypass feature to await several asynchronous download operations in parallel.

Therefore, I've run into this problem again. But this time I've found a work-around: use npm config get [..] to obtain the config value from .npmrc and then set the appropriate environment variable, in the bin/sea-site-build script.

Fix applied in 4d9020074ea7

wu-lee commented 1 year ago

Oh, the map apps will also need to use a deploy script included in mykomap, that works around the problem. But then to use mykomap they will need various alterations along with this.