search

DigitalCommons / mykomap

A web application for mapping initiatives in the Solidarity Economy
3 stars 0 forks source link

Add a mechanism for shipshape to interrogate the sea-map config #155

Closed wu-lee closed 1 year ago

wu-lee commented 2 years ago

Now that the config.json is gone, and use use a javascript config, there needs to be something which exposes that to shipshape.

wu-lee commented 2 years ago

@ColmMassey

ColmMassey commented 1 year ago

The simplest solution may be for a config.json file to also be generated mirroring what is in the Truescript, but compatible with old format, so shipshape still works.

wu-lee commented 1 year ago

This is now implemented and a working version of shipshape deployed on https://dev-1.solidarityeconomy.coop/shipshape/

Latest versions of the coops-uk map has a version of mykomap which exports metadata in a config.json file that sea-map can retrieve. It no longer has version.json and about.html, however - this information is included in config.json. The version this begins working on is v3.0.2.

Some values of the version.json fields, as well as being moved to config.json, have been renamed to mirror the projects renaming to mykomap. For instance, version.seaMapVersion, and version.seaMapResolvedVersion.

sea-map v2.x and mykomap v3.0.0 and v3.0.1 do not provide all (or any) information for shipshape. The production version of coops-uk and obo-public maps still use these.

Therefore shipshape needed to be updated to be aware of these variations, and deal with them accordingly.

On the new version of shipshape, you should see that:

ColmDC commented 1 year ago

Nice. Is there a missing line at the bottom? Is it perhaps the prod version of the oxford project?

wu-lee commented 1 year ago

I can see lines with the prod and dev version of Oxford?

What are missing are those 2.x projects, which mostly don't expose any information.

ColmDC commented 1 year ago

I can see lines with the prod and dev version of Oxford?

It has returned. All good.