Mykomap contains hard-wired terms for "country"

[wu-lee]

Specifically lines like this in view/sidebar/directory.ts

const fieldIsCountries = field => field == "Countries" || field == "Des Pays" || field == "Países" || field == "국가" 

[ColmDC]

Did you resolve this one in your last purge? It's not something I can test.

[wu-lee]

It's not resolved yet. Currently the most obvious way to resolve it is to use a single default term for the "Any" case (translated into the appropriate language).

But that would mean that maps which once showed "All Countries" for this case would then instead show "Any" (or whatever we chose).

If we want something which adapts to the case of the vocab in use, we need a new feature to support that, which allows vocabs to supply their own localised phrases for this case, and/or some way to augment existing vocabs through configuration - but that latter's going to make things more complicated by adding more special cases, I think.

[wu-lee]

I've made the hardwiring a bit less of a fragile hack: instead of checking the translated word against a fixed list of translated words (which may not include all the languages being supported in future), it now looks up the Vocab URI and sees if it matches ^https?://.*/countries-iso/?$ - or in other words, looks like one of the the countries-iso vocabs.

It obviously only works on vocab fields - however I don't think we currently use any country fields which aren't for the directory. This hack is mostly here to support ICA and DotCoop.

From a robustness point of view, still better if they make do with a generic "All Entries" title.

[ColmDC]

For OBO, it says All Entries where ICA says All Counties. Is that hacked in the same way?

[ColmDC]

I think let's drop the use of All Countries ans just use the easier to handle All Entries acroess the board.

[wu-lee]

This is now done - All Items is used in all cases.

Will be deployed to testing with the next batch of fixes.

[ColmDC]

Confirmed that that All Entries is now being used in https://dev.dotcoop.solidarityeconomy.coop/