DigitalCommons / mykomap

A web application for mapping initiatives in the Solidarity Economy
3 stars 0 forks source link

Add remaing fields to ICD dialog #213

Closed ColmDC closed 1 year ago

ColmDC commented 1 year ago

ICD map dialog needs to display the Link to Event and Other (website, social medias) fields, when present in the data.

wu-lee commented 1 year ago

I've asked Amanda if we can split the "Other" field into one per social media platform plus website, no reply yet AFAIK

The problem with having them all in one is that there's no simple way to render them except as a list of links, which is a bit wasteful of space, and ugly.

The event is already linked via the image. Do we need a separate link?

wu-lee commented 1 year ago

Possibly I should just edit the spreadsheet to add those proposed fields?

ColmDC commented 1 year ago

Possibly I should just edit the spreadsheet to add those proposed fields?

Yes, just split it yourself.

wu-lee commented 1 year ago

I've added an explicit "Event" link at the top.

I've also added columns for website, facebook, twitter and email. I'm using the DoCooperation entry to test these by adding the values from their website (or found otherwise).

These seem to work - but note there's no validation. The event link is expected to be there, so there's no validation for that currently. Probably the spreadheet should validate for that?

ColmDC commented 1 year ago

I've added an explicit "Event" link at the top.

I've observed that if there is no event link in the spreadsheet, the link in the dialog defaults to url of the map!

wu-lee commented 1 year ago

Yes - a blank URL normally links to the page it's embedded in

And it's like this because I'm assuming there will be no blank event URLs on the final data set? Otherwise I'd have made the effort to put in something to omit the link entirely.

ColmDC commented 1 year ago

Great. Let's close this one then.