search

DigitalCommons / mykomap

A web application for mapping initiatives in the Solidarity Economy
3 stars 0 forks source link

Markers and dialogs disappearing #220

Closed ColmDC closed 9 months ago

ColmDC commented 9 months ago

Describe the bug Filtering for the county East Timor shows no markers and dialogs and markers remain invisible until all entries is selected.

To Reproduce Go here and follow video Follow video

https://dev.maps.solidarityeconomy.coop/ncba/

Video

Expected behavior The markers and dialog should appear

Desktop (please complete the following information):

wu-lee commented 9 months ago

I think I've fixed this by fixing an (apparently related) problem, in which if the filterableFields config was fields A, B and C then it should have been showing A in the directory - but wasn't, another was used, apparently indeterminately.

This is the reason that in the screen capture above the countryId field (titled "Countries") was being used in the directory, despite the config specifying primaryActivity as the first field in filterableFields.

This fix involved stopping indexing field field indexes with the field titles (a human readable string, not guaranteed unique) with their ID (a unique alphanumeric value).

Fixing this allowed the first item of filterableFields to be used to get the right index directly. Not possible when the indexes were indexed by field title, as the relationship from field to its title is a circuitous one.

Having fixed this, I can't reproduce the issue described above.

The fix is currently deployed on the dev NCBA map, which uses a fixed version of Mykomap (3.1.1)

ColmDC commented 9 months ago

Looks fixed.