DigitalCommons / property-boundaries-service

A service to download updated versions of the land registry property boundaries and serve with company information.
0 stars 0 forks source link

[Backsearch P1]Use standard auth like on the lx backend #8

Open King-Mob opened 10 months ago

King-Mob commented 10 months ago

Can still use the single secret system, but copy the webtoken method from lx-back-end so that every request doesn't have if(!secret || secret != process.env.SECRET) in it

rogup commented 8 months ago

@lin-d-hop What's you reason for making this a P1? IMO this is very minor and can wait, since it doesn't make any difference to users (it isn't a security concern) and not much difference to us as developers, since the service only has 2 routes anyway. The change isn't trivial and using webtokens actually complicates things a bit