DigitalDJ / tinytinyrss-fever-plugin

Tiny Tiny RSS Fever API Plugin
https://github.com/DigitalDJ/tinytinyrss-fever-plugin
GNU General Public License v3.0
207 stars 28 forks source link

Unable to set API password #14

Closed h07d0q closed 3 years ago

h07d0q commented 4 years ago

I installed and activated the plugin but the form to set the password in the accordion menu is not displayed.

meekjt commented 4 years ago

Did you find a solution for this? I'm having the same problem, I'm suspecting it might be a file permissions issue, but haven't figured it out yet.

h07d0q commented 4 years ago

Hi, no I did not find a solution, so I switched to FeedMe on my Android device, which does not use the Fever API.

meekjt commented 4 years ago

Sounds good, I switched to Miniflux using the Fever API, it's working well.

c0per commented 4 years ago

Anyone know how to solve this problem? It's been annoying me.

bosconb commented 4 years ago

same issue,have no idea yet

francois-claude commented 4 years ago

same issue here

black-desk commented 4 years ago

same issue

black-desk commented 4 years ago

Anyone know how to solve this problem? It's been annoying me.

change to this solve it

bitsandnumbers commented 4 years ago

Anyone knows why it happens ? It'd be good not to be stuck with 1.4.7 which is years old now.

So to sum up, we can enable v2.30, the tab shows up but when entering a password nothing's saved and the "password saved" notification does not show up.

I get an error in the logs :

Uncaught Error: Call to a member function prepare() on null in /config/www/tt-rss/plugins.local/fever/init.php:67 Stack trace: #0 /config/www/tt-rss/classes/pluginhandler.php(12): Fever->save() #1 /config/www/tt-rss/backend.php(126): PluginHandler->catchall('save') #2 {main} thrown

Comparing both init.php from 1.4.7 and 2.30 respectively (around line 67) :

1.4.7

function save()
    {
        if (isset($_POST["password"]) && isset($_SESSION["uid"]))
        {
            $result = db_query("SELECT login FROM ttrss_users WHERE id = '" . db_escape_string($_SESSION["uid"]) . "'");
            if ($line = db_fetch_assoc($result))
            {
                $password = md5($line["login"] . ":" . $_POST["password"]);
                $this->host->set($this, "password", $password);
                echo __("Password saved.");
            }
        }
    }

2.30

    function save()
    {
        if (isset($_POST["password"]) && isset($_SESSION["uid"]))
        {
            $sth = $this->pdo->prepare("SELECT login FROM ttrss_users WHERE id = ?");
            $sth->execute([clean($_SESSION["uid"])]);
            if ($line = $sth->fetch())
            {
                $password = md5($line["login"] . ":" . $_POST["password"]);
                $this->host->set($this, "password", $password);
                echo __("Password saved.");
            }
        }
    }

If someone can catch the issue from here ?

eric-pierce commented 3 years ago

This should be fixed by #20 - @bitsandnumbers can you confirm?

bitsandnumbers commented 3 years ago

Sadly I do not use TTRSS anymore, so I've got no running instance to test from.

Maybe @black-desk or @c0per ?

black-desk commented 3 years ago

Sadly I do not use TTRSS anymore, so I've got no running instance to test from.

Maybe @black-desk or @c0per ?

sorry I have switched to freshrss

cheywood commented 3 years ago

Doesn't appear to be working here, first time plugin install. Unsure if there's anything special about my install; I use tt-rss via YunoHost.

A couple of screenshots in case they're useful:

image

image

morgannunan commented 3 years ago

Exact same problem here. The opening and closing form tags are there but there's nothing inside of it.

s3cret commented 3 years ago

Same problem here.

eric-pierce commented 3 years ago

@s3cret can you confirm the version of tt-rss you're using? This change: https://git.tt-rss.org/fox/tt-rss/commit/1f43d7916cda16e9680b9087bda1f52934e8f25b in tt_rss changed the function name which prints "hidden" fields. The plugin has been updated to use that new function, but if you're using this plugin with an old version of TTRSS you may need to update your application, as the developer pushed several changes over the past 6 months which broke plugins like this one.

D3XX3R commented 3 years ago

My fix for this problem was to update TT-RSS. I had a 2 year old version of it installed so no wonder this didn't work.

WladyX commented 3 years ago

I confirm, i also switched to the new docker version and now it works.

eric-pierce commented 3 years ago

@DigitalDJ it sounds like this can be closed!