search

DigitalExcellence / dex-backend

Backend for Digital Excellence Platform
https://dex.software
GNU Lesser General Public License v3.0
21 stars 10 forks source link

Improve user flow when logging in #165

Closed Brend-Smits closed 4 years ago

Brend-Smits commented 4 years ago

Is your feature request related to a problem? Please describe. When the user clicks on the login button, they click on the 'FHICT' button, then get redirected to the backend Identity server, where they have to click "Fontys" again. This is quite confusing for the end-user.

Describe the solution you'd like Upon clicking "Login with FHICT" in the frontend, automatically redirect them through the identity server to the Fontys identity server. This way the user does not see the unstyled IdentityServer, this will improve usability.

It would be preferred if we could make a general way of handling this so we can easily add "Login with Surfcontext" in the future, without having the user going to our Identity server again. Making a re-usable implementation of this streamlines the future login implementations.

Additional context Some people will still need to login with the "local login" in the identity server, we will probably need a new button for this on the frontend "Login with Identity Server" and a flow that does not redirect them through our Identity Server but that uses the old flow.

This issue will require changes in both the backend and in the frontend.

StijnGroenen commented 4 years ago

The local sign-in would only be used by administrators right? In that case, I think that this should be on a separate page. If we are going to add support for local users (and registering a Digital Excellence account etc.) then it should be visible on the normal sign-in page.

Brend-Smits commented 4 years ago

If we are going to add support for local users (and registering a Digital Excellence account etc.) then it should be visible on the normal sign-in page.

I definitely think that in the next semester some sort of Staff panel should be created in which roll manipulation, account removal, etc is possible. This includes a separate page for admin login. However, seeing the development time that would require, I think this is a good temporary solution.

Edit: This would also be better as a separate issue

wotwot563 commented 4 years ago

backend support for a staff panel is already implemented so the new semester shouldnt have that much work on it.