search

DigitalExcellence / dex-frontend

Frontend for the Digital Excellence platform
https://dex.software
GNU Lesser General Public License v3.0
10 stars 5 forks source link

Embed.html desperate needs an upgrade #223

Closed Brend-Smits closed 4 years ago

Brend-Smits commented 4 years ago

Embedding is a functionality that can be used for Fontys to easily embed projects on the Fontys.nl during an open day or something. Currently embeds look like this: https://gyazo.com/6e06161f2c8d39ac04fd09f776ca8978

I asked @MaxKorlaar to temporarily freestyle and fix this design to make it better.

MaxKorlaar commented 4 years ago

image

I've hidden the navigation, footer and beta notice when on an embed page.

In case of an even smaller screen width, the sidebar is placed below the main content.

image

This is currently done by listening to router events, but it is not how it really should be done. Because the <router-outlet> component is part of the layout itself, I can't easily change what layout should be used through the routes definitions.

I think it would be better if done like this: https://stackblitz.com/edit/angular-multi-layout-example?file=app%2Fapp.routing.ts, in which the routes determine which layout gets loaded, with the other components being child components of this layout, making it easier to add new layouts.

Brend-Smits commented 4 years ago

That already looks way better. The tags can also be hidden btw

MaxKorlaar commented 4 years ago

I have commented them out, so that they can be brought back in the future.

Brend-Smits commented 4 years ago

What does @rubenb994 think of your suggestion for a multi-layout routing setup?

rubenb994 commented 4 years ago

Seems like a good solution, hiding all layout elements for certain routes does not feel like something we should implement