Bug/512 homepage like in background

elislaats commented 3 years ago

Description

Recommended project cards now update likes given on an open modal

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I updated the changelog with an end-user readable description
[x] I assigned this pull request to the correct project board to update the sprint board

Go to your homepage, make sure you have recommended projects (like some projects if you dont have recommended projects)
Open your first recommended project
Click like in the modal
Check that the likes on the card in the background are updated too

Closes: #512

waltersajtos commented 3 years ago

Might be a good idea to implement this function on the overview page as well?

MeesvanStraten commented 3 years ago

@waltersajtos Yeah Julia implemented this also on the overview page 👍 Thanks!

waltersajtos commented 3 years ago

@MeesvanStraten @juliaslaats I'm pretty sure the overview page does not implement the modalUtitlity

elislaats commented 3 years ago

@MeesvanStraten @juliaslaats I'm pretty sure the overview page does not implement the modalUtitlity

You are right, the project overview has a separate modal-function, which is weird, I think it's an easy fix, I'll quickly look into it

MeesvanStraten commented 3 years ago

Hmm my bad, I only tested if it synced.

elislaats commented 3 years ago

That makes sense @MeesvanStraten, no problem!

I re-wrote the funtions on the overview page so that they use the modal utility aswell. Would you be so kind to check again that it works well. 😄

@waltersajtos I requested your review too if you happen to have some time. Thanks for pointing the issue out!