DigitalExcellence / dex-frontend

Frontend for the Digital Excellence platform
https://dex.software
GNU Lesser General Public License v3.0
11 stars 6 forks source link

Fixed modal disappearing highlight form #576

Closed NealGeilen closed 3 years ago

NealGeilen commented 3 years ago

Description

Fixed highlight project modal, not disappearing when clicking out of it.

Type of change

Checklist

Steps to Test or Reproduce

  1. Log in as an admin
  2. Open up a project, click the cogwheel.
  3. On popup click higlight settings.
  4. Try to click outside the modal. It does not work.

Link to issue

Closes: #569

MeesvanStraten commented 3 years ago

@NealGeilen I tried testing it but had some problems. With chrome I did not have any problems clicking the highlight away (even before the fix so on staging and prod it works fine). In this branch chrome works fine, but for some reasons i am getting CORS errors when trying to login on Firefox. Did you tested this on chrome and firefox? and did you have problems before the fix with chrome? If you tested with firefox where you able to succesfully login ? or also CORS errors in the developer console?