DigitalExcellence / dex-frontend

Frontend for the Digital Excellence platform
https://dex.software
GNU Lesser General Public License v3.0
10 stars 5 forks source link

Bugfix/562 description field on create project wizard not big enough #582

Closed BartvanEijkelenburg closed 3 years ago

BartvanEijkelenburg commented 3 years ago

Description

A few sentences describing the overall goals of the pull request's commits.

Type of change

Checklist

Steps to Test or Reproduce

Log in into dex. Create a new project. enter a title, click next. On the description page you will see the quill editor, input a lot of words to see if it scales correctly.

Link to issue

Closes: #562

BartvanEijkelenburg commented 3 years ago

The Issue says this:

Expected behavior In the right corner should be a way to increase the size of the box.

I don't see that, I don't think the word-break was the issue? Please tell me if I misunderstood

How do you expect this to work? Overflow outside of the wizard modal? We made it scrollable on purpose because overflowing looked really bad. Feel free to change it tho

Before this ticket, when the description get bigger it would extend to the left and right of the modal causing it to dissappear.

Resizing the window isn't efficient. So I just updated the word-break since this was missing.

elislaats commented 3 years ago

Before this ticket, when the description get bigger it would extend to the left and right of the modal causing it to dissappear.

Resizing the window isn't efficient. So I just updated the word-break since this was missing.

I see, the problem only occurs when a word is longer than the textarea width, not when you just add a very long description in general. THat's why I couldn't see the problem at first.

Maybe next time think about adding a description to your PR so it's easier to check what you've done. Besides that I think this is all good then.