DigitalExcellence / dex-frontend

Frontend for the Digital Excellence platform
https://dex.software
GNU Lesser General Public License v3.0
10 stars 5 forks source link

Bugfix/482 add remove to icon #585

Closed elislaats closed 3 years ago

elislaats commented 3 years ago

Description

The issue described that the removing a project icon on the edit page does not work. In the meantime the whole button had been removed from the layout. And a comment was provided that this was also an issue on the wizard-page. I added the remove-icon-functionality to both the edit page and the wizard.

I added a button to the edit-page. In the wizard I added an overlay for desktop and a button for mobile.

Type of change

Checklist

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here. These steps will be used during release testing.

Edit page

  1. Visit a project-page for a project you can edit
  2. Go to the edit page and (if needed) upload a project icon
  3. See the 'remove' button appear and check that it looks good
  4. Do the same on (devtools) mobile if you want

Wizard

  1. Create a new project
  2. Continue to the step where you're adding an icon
  3. Upload an icon
  4. Check that when you hover the icon it allows you to delete it.
  5. Do the same on mobile, this time it's not an overlay but a button that appears

Link to issue

Closes: #482