Closed Brett55 closed 5 years ago
Merging #713 into dev will decrease coverage by
1.94%
. The diff coverage is82.94%
.
@@ Coverage Diff @@
## dev #713 +/- ##
==========================================
- Coverage 81.47% 79.53% -1.95%
==========================================
Files 91 89 -2
Lines 6397 6239 -158
==========================================
- Hits 5212 4962 -250
- Misses 1185 1277 +92
Impacted Files | Coverage Δ | |
---|---|---|
gbdxtools/rda/fetch/threaded/libcurl/easy.py | 40.98% <0%> (-5.57%) |
:arrow_down: |
gbdxtools/images/modis.py | 86.36% <100%> (ø) |
:arrow_up: |
gbdxtools/rda/interface.py | 100% <100%> (+7.8%) |
:arrow_up: |
tests/unit/test_idaho.py | 100% <100%> (ø) |
:arrow_up: |
tests/unit/test_interface.py | 100% <100%> (ø) |
:arrow_up: |
gbdxtools/images/rda_image.py | 83.33% <100%> (-11.16%) |
:arrow_down: |
gbdxtools/images/base.py | 92.85% <100%> (ø) |
:arrow_up: |
tests/unit/test_ikonos_image.py | 100% <100%> (ø) |
:arrow_up: |
gbdxtools/images/util/image.py | 86.66% <100%> (-0.57%) |
:arrow_down: |
tests/unit/test_radarsat.py | 100% <100%> (ø) |
:arrow_up: |
... and 30 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2efa8d8...cb90681. Read the comment docs.
Can you add a document that describes the workflow for making a template and using it, should we need to add a new image class? Also, if we have to revise or update a template, what are the steps there?
@drwelby I essentially copied the DigitalGlobeStrip template and matched the parameters that are fed to the operators. The real reason I copied the template was in case RDA team changes the template it doesn't break us. Probably pros and cons to using that template as well.
I can make a document that describes how to make a template. I think Graph Studio is best for making templates.
As for updating templates, it is a pain. Currently I have to post a template (PUT is not allowed), and then link that new template Id to its respective metadata so it can be discoverable via tags (search). It's all very error prone and I'd prefer to have real names like DigitalGlobeStrip
, and PUT would be nice.