DigitalGlobe / gbdxtools

(Deprecated) Python SDK for using GBDX
MIT License
74 stars 57 forks source link

Hidden default Type in Catalog search breaks things (and is hidden) #764

Closed drwelby closed 2 years ago

drwelby commented 5 years ago

Catalog.search() has a function call with the default keyword types=[None], but if the keyword is None then sets types = ['Acquisition'].

Using this as a secret default then breaks searches like:

search(searchAreaWkt=wkt, filters=["sensorPlatformName = 'Sentinel1'"]) because Sentinel records aren't included as an Acquisition.

The least confusing thing to do is to keep the default as None to minimize the potential for unexpected behavior.

It is possible that the default was set to Acquisition to filter out 1B records - this needs to be investigated for its potential to break notebook examples.