DigitalHealthIntegration / rdt-reader

MIT License
2 stars 0 forks source link

Resolve LICENSE issues #14

Open rightparen opened 4 years ago

rightparen commented 4 years ago

Audere needs a LICENSE file checked into the repo that we can use to check the client filter code into our open source repo.

The license for the server (including binary model and code) at least needs to allow us to run the server and to modify the code for internal usage. We probably have enough documentation spelled out in Slack and emails that this may not need to be an explicit file.

The license for the model file used by the client filter at least needs to allow us to run and distribute the binary freely. We do need this checked in as a LICENSE file, preferably next to the model file so that we can include the LICENSE along side the file in our client binaries.

We probably need the license for the client code to be compatible with the MIT license. MIT and BSD are both good options here. We need this checked in as a LICENSE file, preferably in a directory above all the source code so that we can include the LICENSE in our repo and specify that IPRD holds copyright on all code underneath.

rightparen commented 4 years ago

Assigning to @kumaakh for now, please feel free to redirect as appropriate.

rightparen commented 4 years ago

In an email thread, @smakthal replied to my comments above, saying:

We agree with what you are outlining below and I think an AGPL license on just the tf-lite model file will still allow you to freely distribute it. If we put the model in a separate folder (Which I think it already is) and put its own LICENSE file in it will that suffice?

All server side code will be in a docker container and remain closed source. IPRD will issue a perpetual license for Audere to use and modify this code without any restrictions/obligations. As you say below, we might not even need a separate LICENSE file since it is documents in emails/Slack. All client side code (Phone App) will be released under the MIT license. The only exception to this will be the tf-lite model file which will be provided to Audere under AGPL.

This all sounds good to me. I think this implies the following changes in the repo:

1) Replace the contents of rdt-reader/LICENSE with text that specifies: (a) IPRD's ownership of copyright, (b) the grant of perpetual rights for Audere that you mention, and (c) a note that specifies that all files in the repo are governed by this license except where a closer LICENSE file overrides. 2) Put a copy of the MIT license that reserves copyright to IPRD in rdt-reader/RDTCamera/LICENSE. 3) Put a copy of AGPL license that reserves copyright to IPRD in rdt-reader/RDTCamera/app/src/main/assets.

Does that work?

kumaakh commented 4 years ago

@smakthal Please work with @kjhanna to resolve this. I can add stock license statements easily but I think @rightparen is indicating that we should refine them as described in the last comment

smakthal commented 4 years ago

@kumaakh I should have the perpetual license text by tomorrow.

On Nov 8, 2019, at 1:31 AM, Akhil Kumar notifications@github.com wrote:  @smakthal Please work with KH to resolve this

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

rightparen commented 4 years ago

@smakthal okay, sounds good.

For now, the main thing blocking me is that I need the MIT license on the Android code and AGPL on the client model. Once those two are in place I can land the client code in our repo.

The perpetual license for the server is helpful, but not urgent.