search

DigitalHealthIntegration / rdt-reader

MIT License
2 stars 0 forks source link

Don't return proof if the alignment has failed #15

Closed kumaakh closed 4 years ago

kumaakh commented 4 years ago

The current service has a bug: when the alignment fails and request has "includeProof" it returns the last proof. It should not return proof in this case. Note: Proof should always be returned if the alignment passed.

kumaakh commented 4 years ago

@anandRIyer can you fix this today

anandRIyer commented 4 years ago

I am working on this now. I'll confirm in a couple of hours.

anandRIyer commented 4 years ago

this is fixed. Now, it works as follows:

  1. Proof required and valid rdt image: metadata json (including result) and the image
  2. Proof required and an invalid rdt image: metadata json (including result - not valid rdt here) and no image.

The above two will be multipart messages.

  1. No proof required: Just metadata json with result. No image