DigitalHolography / Holovibes

Real time, high throughput digital holography software
https://holovibes.com/
Apache License 2.0
17 stars 3 forks source link

Pipe renaming #581

Open Hpn4 opened 3 weeks ago

Hpn4 commented 3 weeks ago
simon-riou commented 2 weeks ago

Most of the function (cuda kernels, wrappers, ...) in pipe takes an input buffer and an output buffer. Rename the name of these buffers to output and input. The best will be to have output as first argument and input as second argument in order to unify with CUDA naming convention.

simon-riou commented 2 weeks ago

In shift_corners, these overloaded functions are never used:

void shift_corners(cuComplex* output,
                   const cuComplex* input,
                   const uint batch_size,
                   const uint size_x,
                   const uint size_y,
                   const cudaStream_t stream);

Any particular reason, or we can simply remove them ?

simon-riou commented 2 weeks ago

I noticed that there are missing tests for some CUDA fonctions, or some are not run in testsuite (might be expected, for example test_reduce.cc), or some doesn't work ... Might create an issue about this