search

DigitalIO / ComfyUI-stable-wildcards

Stable Wildcards Node
MIT License
23 stars 5 forks source link

mouse-over text stopped working #4

Open artkatz opened 7 months ago

artkatz commented 7 months ago

This might be related to the latest Comfy updates. The mouse-over text that should show the prompt with the specific wildcard selections executed, suddenly shows a wrong combo. The "show text"-node, if connected to the output of the stable wildcard node is still showing the real prompt used. But this requires a re-execution of the workflow, while before you could just move back in history or drop an older image into Comfy to see the actual used prompt as a mouse-over. Any fix will be highly appreciated :)

DigitalIO commented 7 months ago

I won't have time to look at this untill next week. PRs welcome in the meantime.

DigitalIO commented 6 months ago

I can't seem to replicate the issue. Do you have a workflow I can take a look at?

artkatz commented 6 months ago

Thanks for taking care. When I tried to set up a most basic workflow to share, suddenly things where fine. It turns out that changing the seed of the stable-wildcard-node to an input and feeding it with an additional Seed-Node causes the troubles described. I tested the Seed-nodes from Comfyroll, WAS and rgthree, they all crash the mouse-over of your node. Sorry for the confusion, no big deal to avoid the Seed-input-nodes. At least that info might be helpful for others who run into that trap. Added the basic workflow including the seed nodes, maybe this can be fixed. stablewildcard-seed-input-workflow.json

DigitalIO commented 6 months ago

Ok, so the trick for the mouse-over-text to update is it looks for a change in the seed widget or the text area. If the seed is another node this node can no longer detect when a change occurs. I would have to dive into the ComfyUI code to see if there were a way to fix that, but I don't quite have the time now to do that.

I'm glad you figured out where the issue was though :)