search

DigitalInBlue / Celero

C++ Benchmark Authoring Library/Framework
Other
822 stars 96 forks source link

Add missing <string> include to use std::string #129

Closed Cheney-W closed 5 years ago

Cheney-W commented 5 years ago

This causes compile failures with VS2019 previews, where \ no longer includes \.

DigitalInBlue commented 5 years ago

Thanks for the update!

mloskot commented 5 years ago

@DigitalInBlue Since VS 2019 is released, would it be worth to release this fix as 2.5.0?

It would help to publish the fixed version with vcpkg and conan.

DigitalInBlue commented 5 years ago

I completely agree. This would be a good (and necessary) update.

On Jun 5, 2019, at 17:50, Mateusz Łoskot notifications@github.com wrote:

@DigitalInBlue Since VS 2019 is released, would it be worth to release this fix as 2.5.0?

It would help to publish the fixed version with vcpkg and conan.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.