Use _WIN32 instead of WIN32 preprocessor macro

DigitalInBlue / Celero

C++ Benchmark Authoring Library/Framework

Other

822 stars 96 forks source link

Use _WIN32 instead of WIN32 preprocessor macro #137

Closed c72578 closed 4 years ago

c72578 commented 4 years ago

_WIN32 is the recommended preprocessor macro

Substitute occurrences of WIN32 with _WIN32 using:

git grep -lw -e 'WIN32' -- | xargs sed -i -e 's/\<WIN32\>/_WIN32/g'

c72578 commented 4 years ago

Some background info concerning the _WIN32 preprocessor macro: https://blog.kowalczyk.info/article/j/guide-to-predefined-macros-in-c-compilers-gcc-clang-msvc-etc..html https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=vs-2019 https://en.wikipedia.org/wiki/C_preprocessor#Conditional_compilation

DigitalInBlue commented 4 years ago

I'm fine with this change, but please do the pull request against develop instead of master according to the git flow model. I will be happy to merge the change then.

c72578 commented 4 years ago

OK, PR against develop created: https://github.com/DigitalInBlue/Celero/pull/138