Cleanup some compiler issues on MacOS. - Githubissues

DigitalInBlue / Celero

C++ Benchmark Authoring Library/Framework

Other

824 stars 95 forks source link

Cleanup some compiler issues on MacOS. #141

Closed jiverson002 closed 4 years ago

jiverson002 commented 4 years ago

In file include/celero/ThreadLocal.h:

thread_local is a C++ keyword so using an #ifdef check for its existence is not reliable. Instead, check for C++11 support to determine if thread_local is already defined. See here https://stackoverflow.com/questions/5047971/how-do-i-check-for-c11-support.
Also the check #if __STDC_VERSION__ >= 201112 is not meaningful, since presumably Celero is being compiled with a C++ compiler, so it has been removed.

In file src/Memory.cpp:

Added include for <cstring> so that strlen and strncmp are defined for Apple environment.

Fixes #140

DigitalInBlue commented 4 years ago

Thank you for the commit. Please enjoy the library!