DigitalInBlue / Celero

C++ Benchmark Authoring Library/Framework
Other
822 stars 96 forks source link

error: loop variable 'udm' of type 'const std::__1::shared_ptr<celero::UserDefinedMeasurement>' creates a copy from type 'const std::__1::shared_ptr<celero::UserDefinedMeasurement>' #142

Closed yurivict closed 3 years ago

yurivict commented 4 years ago

clang-10 fails:

/wrkdirs/usr/ports/benchmarks/libcelero/work/Celero-2.6.0/src/TestFixture.cpp:138:18: error: loop variable 'udm' of type 'const std::__1::shared_ptr<celero::UserDefinedMeasurement>' creates a copy from type 'const std::__1::shared_ptr<celero::UserDefinedMeasurement>' [-Werror,-Wrange-loop-construct]
                for(const auto udm : udms)
                               ^
/wrkdirs/usr/ports/benchmarks/libcelero/work/Celero-2.6.0/src/TestFixture.cpp:138:7: note: use reference type 'const std::__1::shared_ptr<celero::UserDefinedMeasurement> &' to prevent copying
                for(const auto udm : udms)
                    ^~~~~~~~~~~~~~~~
                               &
1 error generated.

Log: http://beefy17.nyi.freebsd.org/data/head-i386-default/p529299_s359382/logs/libcelero-2.6.0.log (IPv6 URL)

Shachlan commented 3 years ago

https://github.com/DigitalInBlue/Celero/pull/146