search

DigitalInBlue / Celero

C++ Benchmark Authoring Library/Framework
Other
822 stars 96 forks source link

CMake config file #156

Closed weirdo-neutrino closed 3 years ago

weirdo-neutrino commented 3 years ago

7f2f1c876d568e5dc0e618f44b64bb52fa66d3a8

Now it uses config-file approach.

a38a4e2367a9eb73667940e053949a8a057c7dd9

Created this as a separate commit, so you can rebase it, if you like. It uses GNUInstallDirs and changes system include path to CMAKE_INSTALL_INCLUDEDIR and system lib path to CMAKE_INSTALL_LIBDIR. The reasons are described in commit message.

06382c1fccae4c0f317adcfdea5553438693949e

Moved find_package(GTest) to the root CMakeLists.txt from test one. It obviously will not be required by any other directory and there is no other dependency either. Though it is a better place to have such commands. The reasons are described in commit message.

ad1900fb2d152ded18ed216ee2f8f0bb9ce0e10e

Removed add_dependecies() commands. The reasons are described in commit message.

2b02c6388ff92bdd779dbd719972e0780c287519

Renamed project from CeleroProject to celero. The reasons are described in commit message.

ae833c7156ec6a2b40691b5f105ea29d74713790

Added warning suppression to experiments. The reasons are described in commit message.

weirdo-neutrino commented 3 years ago

At CMakeLists.txt:27 there is no point in setting POSITION_INDEPENDENT_CODE. As stated by CMake docs "This property is True by default for SHARED and MODULE library targets and False otherwise.".

Right now it is set for all targets regardless of type, if user checks CELERO_COMPILE_PIC.

I don't know your intentions, so I just leave it here.

DigitalInBlue commented 3 years ago

Great updates. Thank you for your investment into the project!