search

DigitalLibraryofTennessee / DLTN_XSLT

XSL Transformations for DLTN Partner Metadata
4 stars 6 forks source link

Add handling for additional form terms for new sets. #312

Closed mlhale7 closed 3 months ago

mlhale7 commented 4 months ago

Associated GitHub Issues: Issue 310

Relevant Links (OAI Feeds, DPLA Records, Metadata Mappings, DLTN Documentation, Etc.) *MCA OAI-PMH - https://cdm17128.contentdm.oclc.org/oai/oai.php

What does this Pull Request do?

This PR adds handling to deal with new form terms present in Montgomery County Archives' metadata for the June 2024 DPLA ingest.

How should this be tested?

Use the mcatestdata.txt in Oxygen (change extension to .xml) with the edited transform to see if the form terms and typeOfResource values show up correctly.

Additional Notes

@mkaljns - I'm putting you on this PR as I don't know who else to include. The changes are pretty minimal. I'll add you to the DLTN organization so you can have access to the code? I think I can convert you to an outside collaborator once the invite is accepted.

mlhale7 commented 3 months ago

@mkaljns - I don't have any concerns about this update doing what it should. I do need to make all edits to DPLA data before Friday of next week (June 21st). I'm okay with a general "looks good" review at this time (given that I have confidence in the simple edits made). Let me know how you'd like to proceed.

mlhale7 commented 3 months ago

I can also push the changes to the server and wait for a formal review until later

mlhale7 commented 3 months ago

@mkaljns - thanks for this. I just realized I didn't communicate initially that there was any deadline and with the Juneteenth holiday things are tight next week. Merging is still blocked (perhaps because you're not part of the DLTN organization?). I believe I sent an invite last week, but I understand if it isn't appropriate for you to be added. I can ask if someone else would be willing to give the thumbs up in the organization even if they don't necessarily understand the XSLT (@carolynfrunyon - would you be willing to help? This request is due to Mark leaving UTK).