search

DigitalMomentum / MetaMomentum

An Umbraco Metadata Property Editor to manage Search engine results, open Graph and Twitter cards
9 stars 8 forks source link

Labels are broken in Momentum for Umbraco 10 #12

Closed martinlcp closed 1 year ago

martinlcp commented 2 years ago

momentum broken v10

The labels seem to be out of alignment and not how they were appearing in previous releases....

Edit_SEO_Screenshot

dinc5150 commented 2 years ago

Thanks @martinjgriffiths, I've just checked a couple of my V10 sites which are using the latest dev build and they look OK. The new build is using the latest UUI updates, and I was reluctant to release the update before testing them in my own sites as UUI is so new, but they are working much better than the screenshots above, so I'll try and get a release update out to you shortly.

In the meantime, if your able to update to 2.2.0-alpha and test it out, that would be great: https://www.myget.org/feed/digital-momentum/package/nuget/MetaMomentum https://www.myget.org/feed/digital-momentum/package/nuget/MetaMomentum.Core

Even though they have been marked as Alpha, I have them running on a couple of production sites, so should be pretty stable.

martinlcp commented 2 years ago

@dinc5150 Hey David

Tried Nuget'ing got following error....

NU1102: Unable to find package MetaMomentum with version (>= 2.2.0-beta)

dinc5150 commented 2 years ago

Hi @martinjgriffiths ,

My only thought is that maybe you haven't configured to use the MyGet source or the wrong source is selected?

Try installing using the following commands which specifies the MyGet source:

Install-Package MetaMomentum.Core -Version 2.2.0-beta -Source https://www.myget.org/F/digital-momentum/api/v3/index.json

Install-Package MetaMomentum -Version 2.2.0-beta -Source https://www.myget.org/F/digital-momentum/api/v3/index.json

martinlcp commented 2 years ago

@dinc5150 Many thanks, you're right I didn't notice it was a different repo. Once configured I could install the package. The improvements are lovely, I really like your social icon buttons, a great idea! The labels are aligned properly now too.

image

One very small note, imo there's a bit of a UI smell around widget width in Umbraco. Some default to roughly 3/4 of the usable screen container width. Some (nested content) take up the full width and a few are configurable (small, medium, large). Can I recommend you add the overlay size option?

image

dinc5150 commented 1 year ago

Thanks, I'll have to do some research into the sizing. It usually refers to the overlay in the popup window, but I'm not sure if there would be a standardised set of widths in the main window of the property editor. I'll chat to some other package devs to see how they have approached the problem.