DigitalNoteXDN / OLD-digitalnote

Base core code for DigitalNote
11 stars 10 forks source link

New features for Daemon #7

Open AuCRHI opened 6 years ago

AuCRHI commented 6 years ago

We need to implement the following methods in the DigitalNote XDN Daemon :

If you have the time and skills to do this please help.

campurro commented 6 years ago

get_transfers support for filtering by min/max height done: https://github.com/DigitalNoteXDN/digitalnote/pull/9

campurro commented 6 years ago

It would be also interesting to take a look at get_bulk_payments ( https://www.getmonero.org/resources/developer-guides/wallet-rpc.html#get_bulk_payments ).

AuCRHI commented 6 years ago

Yes I agree

skironDotNet commented 5 years ago

Why do you try to turn XDN (Cryptonote) into BTC based API? Wallet daemon implements that this, and that's great. You can have only 1 digitalnoted daemon running to sync BC and multiple wallet daemons to work with multiple wallets. I have integrated XDN for payments as is, no problem.

Wallet has those methods: "getbalance" "transfer" "store" "get_messages" "get_payments" "get_transfers" "get_transfer_by_txid" "get_height" "reset"

Daemon has those methods "getinfo" "getheight" "gettransactions" "sendrawtransaction" "start_mining" "stop_mining" "stop_daemon" "getblockcount" "on_getblockhash" "getblocktemplate" "getcurrencyid" "submitblock" "getlastblockheader" "getblockheaderbyhash" "getblockheaderbyheight"

You don't have "getaddress" because address is static, and paymentID can be generated in any programming lang easy

skironDotNet commented 5 years ago

As for transfer you have it simplewallet in RPC mode https://github.com/skironDotNet/digitalnote/wiki/RPC-Walllet-Integration

skironDotNet commented 5 years ago

The problem is that daemon and simplewallet do own things, and integration is harder, for example to get balance I need to call simplewallet RPC but to get block hash by block number I need to call daemon RPC (digitalnoted), so would be nice is simplewallet could passthru all calls relevant to daemon...

AuCRHI commented 5 years ago

Mate please contact me on my direct email if you can.

The DigitalNote XDN dev team AuCRHI

On 4 Dec 2018, at 06:40, Pawel Cioch notifications@github.com wrote:

The problem is that daemon and simplewallet do own things, and integration is harder, for example to get balance I need to call simplewallet RPC but to get block hash by block number I need to call daemon RPC (digitalnoted), so would be nice is simplewallet could passthru all calls relevant to daemon...

....XDN is so behind monero, it doesn't even have RPC method to get block hash by number :(

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DigitalNoteXDN/digitalnote/issues/7#issuecomment-443862161, or mute the thread https://github.com/notifications/unsubscribe-auth/AjaLbGmK9x_HkPz5sFBbLwNXODLxTeuGks5u1YxKgaJpZM4XidjB.

Kou-XDN commented 5 years ago

The problem is that daemon and simplewallet do own things, and integration is harder, for example to get balance I need to call simplewallet RPC but to get block hash by block number I need to call daemon RPC (digitalnoted), so would be nice is simplewallet could passthru all calls relevant to daemon...

Hi Skiron, may you please join our discord and private message me?

Link to discord: https://discord.gg/E6NQYwh

PM myself, Kou [Hulk]

I would like to chat with you and propose a potential offer :).

eightmin commented 5 years ago

Hey,

Still there is an issue. First of all by using xdn wallet for mining I can operate with it only on one ip address, whereas on second not. Using xrig or else it doesn?t count for a hash job?

From: Kou-XDN notifications@github.com Reply-To: DigitalNoteXDN/digitalnote reply@reply.github.com Date: Wednesday, 5 December 2018 at 13:19 To: DigitalNoteXDN/digitalnote digitalnote@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [DigitalNoteXDN/digitalnote] New features for Daemon (#7)

The problem is that daemon and simplewallet do own things, and integration is harder, for example to get balance I need to call simplewallet RPC but to get block hash by block number I need to call daemon RPC (digitalnoted), so would be nice is simplewallet could passthru all calls relevant to daemon...

Hi Skiron, may you please join our discord and private message me?

Link to discord: https://discord.gg/E6NQYwh

PM myself, Kou [Hulk]

I would like to chat with you and propose a potential offer :).

? You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

skironDotNet commented 5 years ago

@AuCRHI I'm not sure where I can find your email.

@Kou-XDN I'll contact you later

@eightmin I don't know what mining has to do with IP address. You can mine using all kinds of software or solo mine using miner.exe (was attached), you don't have to mine via GUI, in fact I generally have no idea what your particular case has to do with "new features for daemon"

eightmin commented 5 years ago

Just saying, that from other location /ip/ mining on wallet is vivid on website, and now I am mining with no presence on website, and I tried it a few times earlier- no hash input comes to my user?

From: Pawel Cioch notifications@github.com Reply-To: DigitalNoteXDN/digitalnote reply@reply.github.com Date: Wednesday, 5 December 2018 at 20:24 To: DigitalNoteXDN/digitalnote digitalnote@noreply.github.com Cc: "info@hedging-advisory.com" info@hedging-advisory.com, Mention mention@noreply.github.com Subject: Re: [DigitalNoteXDN/digitalnote] New features for Daemon (#7)

@AuCRHI I'm not sure where I can find your email.

@Kou-XDN I'll contact you later

@eightmin I don't know what mining has to do with IP address. You can mine using all kinds of software or solo mine using miner.exe (was attached), you don't have to mine via GUI, in fact I generally have no idea what your particular case has to do with "new features for daemon"

? You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

AuCRHI commented 5 years ago

Hi you can use dev@digitalnote.biz

Many thanks

The DigitalNote XDN dev team AuCRHI

On 6 Dec 2018, at 05:20, Pawel Cioch notifications@github.com wrote:

@AuCRHI https://github.com/AuCRHI I'm not sure where I can find your email.

@Kou-XDN https://github.com/Kou-XDN I'll contact you later

@eightmin https://github.com/eightmin I don't know what mining has to do with IP address. You can mine using all kinds of software or solo mine using miner.exe (was attached), you don't have to mine via GUI, in fact I generally have no idea what your particular case has to do with "new features for daemon"

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DigitalNoteXDN/digitalnote/issues/7#issuecomment-444609141, or mute the thread https://github.com/notifications/unsubscribe-auth/AjaLbDu_6cdQsFm6ALfp_d3yr_zRnjdVks5u2BxogaJpZM4XidjB.

Kou-XDN commented 5 years ago

join our discord brother pls we need someone like you :)

-------- Original Message -------- Subject: Re: [DigitalNoteXDN/digitalnote] New features for Daemon (#7) From: eightmin notifications@github.com Date: Wed, December 05, 2018 7:56 pm To: DigitalNoteXDN/digitalnote digitalnote@noreply.github.com Cc: Kou-XDN hulk@digitalnote.biz, Mention mention@noreply.github.com

Just saying, that from other location /ip/ mining on wallet is vivid on website, and now I am mining with no presence on website, and I tried it a few times earlier- no hash input comes to my user? From: Pawel Cioch notifications@github.com Reply-To: DigitalNoteXDN/digitalnote reply@reply.github.com Date: Wednesday, 5 December 2018 at 20:24 To: DigitalNoteXDN/digitalnote digitalnote@noreply.github.com Cc: "info@hedging-advisory.com" info@hedging-advisory.com, Mention mention@noreply.github.com Subject: Re: [DigitalNoteXDN/digitalnote] New features for Daemon (#7) @AuCRHI I'm not sure where I can find your email. @Kou-XDN I'll contact you later @eightmin I don't know what mining has to do with IP address. You can mine using all kinds of software or solo mine using miner.exe (was attached), you don't have to mine via GUI, in fact I generally have no idea what your particular case has to do with "new features for daemon" ? You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread. —You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

skironDotNet commented 5 years ago

Well, I'm not c++ dev, but C#, the fact I can read c++ more or less is one thing, but I can't not desire write c++ If XDN was translated to C# I would fix so many things already. I do have experience with RPC integration of XDN, XMR. BTC... so almost all coins :)