search

DigitalOceanPHP / Client

DigitalOcean API v2 client for PHP
MIT License
709 stars 205 forks source link

Resolves toin0u/DigitalOceanV2#206 #209

Closed tspencer244 closed 5 years ago

tspencer244 commented 6 years ago

These are the changes to make the library PHP 7.1+. Don't see how HHVM support can continue. Recommend tagging this as release 3.0.0.

GrahamCampbell commented 6 years ago

Actually resolves https://github.com/toin0u/DigitalOceanV2/issues/195 I think?

GrahamCampbell commented 6 years ago

Could you send the new GuzzleHttpAdapterSpec as a separate PR please? That can get merged right away.

tspencer244 commented 6 years ago

Could you send the new GuzzleHttpAdapterSpec as a separate PR please? That can get merged right away.

See #219 for the separate PR

GrahamCampbell commented 5 years ago

I can't merge this in it's current state, because it breaks support for the old version of buzz, and renames classes, breaking existing code.

GrahamCampbell commented 5 years ago

Hmmm, will make master 3.x, and fix the version of buzz needed in the docs for 2.x.

Thanks for the PR. 🍻 🍻 🍻