search

DigitalOceanPHP / Client

DigitalOcean API v2 client for PHP
MIT License
710 stars 205 forks source link

[4.0] DomainRecord create method missing optional name attribute for NS records #266

Closed LewisSmallwood closed 3 years ago

LewisSmallwood commented 3 years ago

Here is a proposed solution for:

265 DomainRecord create method missing optional name attribute for NS records

It also adds a check to see if the name attribute is not set, in which case, it will default back to "@" to maintain backwards compatibility with older versions of the Client.

LewisSmallwood commented 3 years ago

Contrary to the documentation from DO, the name attribute is required. Without it this error is thrown:

image

I have updated the PR accordingly.

GrahamCampbell commented 3 years ago

Can you contact them about this issue, please?

GrahamCampbell commented 3 years ago

Thanks for working on this. :)

LewisSmallwood commented 3 years ago

Can you contact them about this issue, please?

@GrahamCampbell Yes, of course. I raised it with their partner team so it should be updated soon.

Thanks for merging it in. How often are the releases scheduled?