search

DigitalOceanPHP / Client

DigitalOcean API v2 client for PHP
MIT License
710 stars 205 forks source link

PHP 7.4 requirement #302

Closed sdwru closed 2 years ago

sdwru commented 2 years ago

Any chance you can lower that to php 7.3? We still use that for several things and it would be difficult to upgrade.

GrahamCampbell commented 2 years ago

No plans. If you are happy with an EOL version of PHP, you can also be happy with an older version of this library, from before we dropped support. :)

GrahamCampbell commented 2 years ago

v4.4.0 was the last release to support PHP 7.3.

sdwru commented 2 years ago

If the reason is because 7.3 is EOL there is no reason to enforce that in a peripheral library imo. This library has not been keeping up with changes to the API, seems to me that should be a higher priority. We are probably going to have to fork this now because we need the changes that we ourselves have submitted pull requests on. There won't be much incentive to do that once we are using our own fork.

GrahamCampbell commented 2 years ago

I'd highly recommend putting in the effort to upgrade to PHP 7.4.

sdwru commented 2 years ago

I'd highly recommend putting in the effort to upgrade to PHP 7.4.

WHMCS has only started supporting PHP 7.4 with their latest release and I don't see them supporting PHP 8 anytime soon. I have no control over that.

As I said before, if your reason for doing it is because 7.3 is EOL that shouldn't be enforced in a peripheral library anyways imo. Anyone who wants/needs to use a newer version still can.