DigitalPebble / behemoth

Behemoth is an open source platform for large scale document analysis based on Apache Hadoop.
Other
281 stars 60 forks source link

Multiple code improvements - common-java:DuplicatedBlocks, squid:S00112, squid:S134, squid:MethodCyclomaticComplexity, squid:HiddenFieldCheck, squid:S1172 #60

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules common-java:DuplicatedBlocks - Source files should not have any duplicated blocks. squid:S00112 - Generic exceptions should never be thrown. squid:S134 - Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply. squid:MethodCyclomaticComplexity - Methods should not be too complex. squid:HiddenFieldCheck - Local variables should not shadow class fields. squid:S1172 - Unused method parameters should be removed. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/common-java:DuplicatedBlocks https://dev.eclipse.org/sonar/rules/show/squid:S00112 https://dev.eclipse.org/sonar/rules/show/squid:S134 https://dev.eclipse.org/sonar/rules/show/squid:MethodCyclomaticComplexity https://dev.eclipse.org/sonar/rules/show/squid:HiddenFieldCheck https://dev.eclipse.org/sonar/rules/show/squid:S1172 Please let me know if you have any questions. George Kankava