search

DigitalRiver / react-atlas

Composable React components with CSS Modules.
http://digitalriver.github.io/react-atlas/
MIT License
38 stars 25 forks source link

Replace react-css-modules #198

Open hbowden opened 7 years ago

hbowden commented 7 years ago

Right now themeing in Atlas is partially done at compile time by codegen. However some themeing is still done at runtime by react-css-modules. Replacing react-css-modules with a webpack or babel plugin that does styleName transformations at compile time, should improve initial rendering performance by 60%, shrink bundle size by around 115KB because we can remove Lodash and react-css-modules and get rid of stylename warnings, an example of the warning is below.

stylename

Raymans commented 7 years ago

We could turn \<InputCore> to \<Input> to get rid of this warning and this also can apply Input component's styleName which is inside Checkbox as child, but once applied child input classes then needs to adjust style changes for Checkbox component.