DigitalRiver / react-atlas

Composable React components with CSS Modules.
http://digitalriver.github.io/react-atlas/
MIT License
38 stars 25 forks source link

Accordion component does not work in docsite. #768

Closed hbowden closed 6 years ago

hbowden commented 6 years ago

The Accordion component does not work inside styleguidist. However it works in the react atlas test site (RATS), and other standalone applications.

hbowden commented 6 years ago

By not work I mean the Accordion component does not open when clicked on, below is a video showing the problem: https://www.screencast.com/t/MEWdnldw

Darper commented 6 years ago

This is because cwrp is checking nextProps.children !== this.state.children, but this.state.children is undefined. This can be fixed by changing the conditional to nextProps.children !== this.props.children.

Darper commented 6 years ago

Fixed by #783