search

DigitalRiver / react-atlas

Composable React components with CSS Modules.
http://digitalriver.github.io/react-atlas/
MIT License
38 stars 25 forks source link

<Table>'s insertRow prop not working properly in RATS #942

Open floydchenchen opened 5 years ago

floydchenchen commented 5 years ago

  1. Our <Table> component is not working properly when an insertRow prop is passed in. According to react-boostrap-table insertRow prop it should open up a new modal that allows customization.

  2. By simply change our <TableHeader> component and <Table> to react-bootstrap-table's <TableHeaderColumn> and <BootstrapTable> will fix the problem

  3. It is apparently not a issue of the version we are using the library since we are using the latest one.

floydchenchen commented 5 years ago

image

Magneticmagnum commented 5 years ago

only in rats?

floydchenchen commented 5 years ago

@Magneticmagnum never used the prop in other places, but I guess not just RATS