[ ] Line 57: Add comment to inform that we are checking for a string in case the user uses an HTML element instead of a React Node, in which case boolean attributes aren't allowed
[ ] Lines 115-116: Remove the titlePosition prop and allow user to set positioning/style by passing through a Node instead of a String to the title prop.
[ ] Line 118: Remove header-inactive class and make that the default styling. Only overwrite when active.
[ ] Lines 130-131: Do we need these?
[ ] Line 134: Remove unnecessary wrapper div. Replace with React.Fragment if wrapper is needed.
[ ] Line 168: Wrap message in <Text> component.
[ ] Line 197: Allow expandAll prop to be either boolean or string. If string, use that value instead of messages.expandAll on line 168.
AccordionPanel.js
[ ] Line 17: Delete panelStyles variable and just set styleName=cx("accordionPanel") on div.
[ ] Line 49: Set prop type for title to PropTypes.node to allow user to pass in any element. Check styling to make sure end user has full control over the header section when adding a title element.
Darper
commented
5 years ago
Accordion.js
titlePositionprop and allow user to set positioning/style by passing through a Node instead of a String to thetitleprop.header-inactiveclass and make that the default styling. Only overwrite when active.<Text>component.expandAllprop to be either boolean or string. If string, use that value instead ofmessages.expandAllon line 168.AccordionPanel.js
panelStylesvariable and just setstyleName=cx("accordionPanel")on div.titleto PropTypes.node to allow user to pass in any element. Check styling to make sure end user has full control over the header section when adding a title element.