search

DigitalRiver / react-atlas

Composable React components with CSS Modules.
http://digitalriver.github.io/react-atlas/
MIT License
38 stars 25 forks source link

Add snapshot test to dialog.test.js #962

Open Darper opened 5 years ago

Darper commented 5 years ago

The previous snapshot test was returning a false positive so it was deleted. This was caused by something in Portal.js, most likely ReactDOM.unstable_renderSubtreeIntoContainer() which has been replaced by ReactDOM.createPortal(). Please investigate.

FacuRossi commented 5 years ago

I would like to work in this test.

Darper commented 5 years ago

@FacuRossi Thanks! Let us know if you identify a solution. I spent a little time trying to implement ReactDOM.createPortal() but could never actually get any content to show up with the modal.