Add snapShot test for dialog component

DigitalRiver / react-atlas

Composable React components with CSS Modules.

http://digitalriver.github.io/react-atlas/

MIT License

38 stars 25 forks source link

Add snapShot test for dialog component #964

Open FacuRossi opened 5 years ago

CLAassistant commented 5 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Your Name seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

hbowden commented 5 years ago

@FacuRossi Thanks for the pr! It looks good from looking at the diff. I'll pull it down and test it and merge in like 15 or 20 minutes I'm just finishing something up. Thanks again for the work.

Darper commented 5 years ago

Hi @FacuRossi. Can you sign the CLA? We'll need it to merge your contribution. Thanks!

Darper commented 5 years ago

Also, children is a required property for Dialog. Please add some example children to make your new test pass then update your snapshot file using npm run updateSnapshot.

Darper commented 5 years ago

The snapshot test is still failing. children are required, so