Form example causing js error - disabled prop example should use string, not boolean

DigitalRiver / react-atlas

Composable React components with CSS Modules.

http://digitalriver.github.io/react-atlas/

MIT License

38 stars 25 forks source link

Form example causing js error - disabled prop example should use string, not boolean #978

Closed stuller closed 5 years ago

stuller commented 5 years ago

On the doc site, there is a disabled field in the example for Form that is causing a JS prop type error. The disabled field is passing disabled prop as a boolean, but it should be used as a string according to prop types.

Derek will investigate whether we should change this prop to accept booleans as well, but in the meantime could you please update the example to use a string instead of boolean?

This is the error being displayed:

anneswanson commented 5 years ago

Fixed with https://github.com/DigitalRiver/react-atlas/pull/985