search

DigitalRiver / react-atlas

Composable React components with CSS Modules.
http://digitalriver.github.io/react-atlas/
MIT License
38 stars 25 forks source link

Form hideErrors prop should not be passed down to html form element #979

Closed stuller closed 5 years ago

stuller commented 5 years ago

The doc site has a js error caused by the hideErrors prop getting passed down to the html form element: image

Fix should just be adding hideErrors to the blacklist in this line like so: const othersFiltered = blacklist(others, "onSubmit", "hideErrors");

That will prevent it from getting added to the

dom element, since it only gets othersFiltered.

You'll need to update snapshot test as well before putting in a PR.

anneswanson commented 5 years ago

Fixed with https://github.com/DigitalRiver/react-atlas/pull/986