Icon Review Updates - Githubissues

DigitalRiver / react-atlas

Composable React components with CSS Modules.

http://digitalriver.github.io/react-atlas/

MIT License

38 stars 25 forks source link

Icon Review Updates #996

Open Darper opened 5 years ago

Darper commented 5 years ago

Make the following changes found during a code review of the Icon component:

Update classes in docs from "fa" to "fab"
Update docs to tell user to include their own icon library and update classes
Include code snippet to show how to use font-awesome
Mark icon prop as required
Remove console.warn on line 14
Allow ...others
Remove onClick as it is included in ...others
Change large to compose from .font-size-1 and small to use .font-size-5